Polish #42095
Closed
Polish #42095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arefbehboudi
commented
Sep 3, 2024
arefbehboudi
commented
- Remove any unnecessary exception throws to streamline the code.
- Use Lambda Expression
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Sep 3, 2024
| } | ||
|
|
||
| @Override | ||
| public boolean checkResource(Locale locale) throws Exception { |
There was a problem hiding this comment.
This is a breaking change as the method is public API. Please revert.
There was a problem hiding this comment.
Thank you for the review. I’ve updated the code to address the points you mentioned. Please have another look when you have a chance.
wilkinsona
approved these changes
Sep 3, 2024
wilkinsona
added
type: task
Closed
wilkinsona
pushed a commit
that referenced
this pull request
Sep 3, 2024
wilkinsona
added a commit
that referenced
this pull request
Sep 3, 2024
|
Thanks, @arefbehboudi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.